Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to decap 3 #42

Merged
merged 1 commit into from
Dec 20, 2023
Merged

move to decap 3 #42

merged 1 commit into from
Dec 20, 2023

Conversation

SallyMcGrath
Copy link
Member

  • upgrade CMS to decap 3
  • hopefully this will resolve some of the editor issues
  • check:
    • spacebar bug
      -- grammarly limiter

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for cyf-pd ready!

Name Link
🔨 Latest commit a60601e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-pd/deploys/6581d13f39ece70009c0e42f
😎 Deploy Preview https://deploy-preview-42--cyf-pd.netlify.app/admin
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023

Sally McGrath left a comment:

recording

fixed!

Browser metadata 
Path:      /admin/#/collections/blocks/entries/testing/index
Browser:   Chrome 119.0.0.0 on Mac OS 10.15.7
Viewport:  1512 x 855 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@SallyMcGrath
Copy link
Member Author

@kfklein15 I think it's fixed. Take a look?

kfklein15
kfklein15 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@kfklein15 kfklein15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on the deploy and it works. Thank you, Sally!

@SallyMcGrath SallyMcGrath merged commit 4f03ff0 into main Dec 20, 2023
4 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/decap-3 branch December 20, 2023 09:56
@kfklein15 kfklein15 mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfklein15 kfklein15 kfklein15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SallyMcGrath @kfklein15